fix(autocomplete): scroll options below fold into view #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
force-pushed
the
autocomplete-scroll
branch
5 times, most recently
from
fbc1088
to
8a389af
Compare
| private _scrollToOption(): void { | ||
| const optionOffset = this._keyManager.activeItemIndex * AUTOCOMPLETE_OPTION_HEIGHT; | ||
| const newScrollTop = | ||
| Math.max(0, optionOffset - MD_AUTOCOMPLETE_PANEL_HEIGHT + AUTOCOMPLETE_OPTION_HEIGHT); |
There was a problem hiding this comment.
Remove the MD_ prefix? Looks like this would give errors
There was a problem hiding this comment.
Yikes! Thanks for catching. Must have messed up the renaming option in WebStorm.
andrewseguin
approved these changes
Jan 25, 2017
andrewseguin
added
pr: lgtm
action: merge
kara
force-pushed
the
autocomplete-scroll
branch
from
8a389af
to
652df12
Compare
kara
added a commit
that referenced
this pull request
Jan 25, 2017
kara
added a commit
to kara/material2
that referenced
this pull request
Feb 3, 2017
kara
added a commit
to kara/material2
that referenced
this pull request
Feb 3, 2017
kara
added a commit
that referenced
this pull request
Feb 3, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @jelbourn. Will need rebase.